Repository navigation
Add third-party test for cumsum with axis=None and out - #3088
Merged
Merged
Conversation
Backport test_cumsum_no_axis to cover cumsum on a 2-D input with axis=None and a 1-D out array in C and F order, and check that the input array is not modified.
antonwolfy
requested review from
ndgrigorian and
vlad-perevezentsev
as code owners
October 7, 2026 10:40
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.21.0dev13=np2py314h8d9cdd5_6 ran successfully. |
Collaborator
|
No base build to compare — add-cumsum-no-axis-out-test into master |
vlad-perevezentsev
approved these changes
Oct 12, 2026
vlad-perevezentsev
left a comment
vlad-perevezentsev
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Thank you @antonwolfy
github-actions Bot
added a commit
that referenced
this pull request
Oct 12, 2026
This PR adds `test_cumsum_no_axis` to the third-party `TestCumsum` suite in `dpnp/tests/third_party/cupy/math_tests/test_sumprod.py` aligning with CuPy test suite. - [x] Have you provided a meaningful PR description? - [x] Have you added a test, reproducer or referred to an issue with a reproducer? - [x] Have you tested your changes locally for CPU and GPU devices? - [x] Have you made sure that new changes do not introduce compiler warnings? - [ ] Have you checked performance impact of proposed changes? - [ ] Have you added documentation for your changes, if necessary? - [ ] Have you added your changes to the changelog? 56fc4ab
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
test_cumsum_no_axisto the third-partyTestCumsumsuite indpnp/tests/third_party/cupy/math_tests/test_sumprod.pyaligning with CuPy test suite.